You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just did a quick switch-a-roo to put this in nativeBuildInputs (see this answer for why). Thanks!
Could you elaborate on that? Because I always use buildInputs for all my devshells and have never had problems with that and the post seems to suggest that it just doesn't make a difference
So, my answer was about to be that outside of cross-compiling, there are other distinctions when it comes to *Inputs such as in regard to shell hooks. However, that means I missed the literal first line which states clearly that for mkShell it doesn't matter. Looking in the source for mkShell, that tracks, everything is outputted together: nixpkgs/pkgs/build-support/mkshell/default.nix
This also reminded me of the existence of inputsFrom and packages. packages is the mkShell-specific attribute that I would wager was added in order to side-step the confusion of *Inputs in a shell, I would recommend using that for most cases. inputsFrom is very special in that it lets you use the dependencies from a package, the reason we don't use it in this shell is because it doesn't include the transitive dependencies needed for Qt to work (and which we have to wrap the Python executable for, which that wouldn't do either). That, and what it would include is all the Python dependencies from nixpkgs, which in this case is undesirable. Otherwise, I would recommend it.
TL;DR: I was wrong, and I am switching the shell to use a single packages list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If you don't have pyright installed on the system, the commit hook in the dev shell will fail.
This PR adds pyright to the devshell to fix that issue.
Tasks Completed